[PATCH] D76640: [GlobalISel] Combine (x op 0) -> x for operations with a right identity of 0

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/CombinerHelper.h:222
+  /// \p C.
+  bool matchConstantOp(const MachineOperand &MOP, int64_t C);
+
----------------
dsanders wrote:
> arsenm wrote:
> > paquette wrote:
> > > aemerson wrote:
> > > > arsenm wrote:
> > > > > The people on your twitter poll are insane and MO is the clearly dominant abbreviation
> > > > Yes, this is terrible. And for that reason, I'm out.
> > > 58.93 twitter users agree that MOP is the morally superior abbreviation
> > There's no word beginning with P here
> FWIW, I'd prefer it if we didn't invent unconventional conventions when there already is a conventional convention
> 
> Also,
> grep -rw MO llvm/ | wc -l    
>     5113
> grep -rw MOP llvm/ | wc -l    
>      100
> grep -rw MOp llvm/ | wc -l
>       21
> :-)
+1.
MO has been the convention for quite some time now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76640/new/

https://reviews.llvm.org/D76640