[PATCH] D76885: [lld][COFF][ELF][WebAssembly] Replace --[no-]threads /threads[:no] with --threads={1,2,...} /threads:{1,2,...}

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 31 08:49:26 PDT 2020


MaskRay added a comment.

In D76885#1951714 <https://reviews.llvm.org/D76885#1951714>, @ruiu wrote:

> Instead of `--threads=all`, can you use `--threads`? `--threads` has several advantages over `--threads=all`:
>
> - it is consistent with other command such as `make`, which takes `-j` for "all" and `-jN` for N threads
> - it is compatible with gold
> - "all" isn't technically very accurate. A more accurate option name would be something like `--threads=same-as-cpu-threads`, but that's fringe. By eliminating an argument, we can avoid naming it.
>
>   If we are doing this, I'd like to see this to be added to the ELF version.


Nobody uses `--threads`. I will delete --threads=all. Let's wait for other opinion whether we need an options restoring the default behavior.

One argument for `--threads=all` is that `--thinlto-jobs=all` is supported, but this point will be moot if we are going to revisit it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76885/new/

https://reviews.llvm.org/D76885





More information about the llvm-commits mailing list