[PATCH] D76759: [AssumeBundles] Preserve Information from Load/Store

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/IR/KnowledgeRetention.cpp:202
+        addAttr(Attribute::NonNull, Pointer);
+    }
+    if (MA.valueOrOne() > 1)
----------------
Tyker wrote:
> jdoerfert wrote:
> > I wonder if we have to guard the `nonnull` stuff with `DerefSize != 0`. This is only needed if we have "no-op" 0-length accesses, I think. I doubt those exist. Wdyt?
> i have not seen an example where DerefSize is 0 but since we obtain a minimum size it wouldn't surprise me if it did exist.
> if you think it is fine without the check i can remove it.
Your right, it seems unlikely. Let's keep it like this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76759/new/

https://reviews.llvm.org/D76759