[PATCH] D75741: AMDGPU: Add check to recompute merge-able instructions
David Stuttard via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 31 07:44:43 PDT 2020
dstuttard added a comment.
In D75741#1926383 <https://reviews.llvm.org/D75741#1926383>, @tstellar wrote:
> How would it invalidate the list? Isn't the analysis of which instructions can be moved done one list at a time?
My impression (perhaps incorrect) was that the original code built a list of lists of instructions in a block that can be optimised.
My change keeps a list of instructions that have been moved when processing one list - and if those instructions are found in another unprocessed list it sets an invalid flag. This forces a re-computation of the un-optimised instructions thus making the iterators valid again. I thought this wouldn't be too expensive as I suspect this very rarely happens (hence the reason that we haven't picked up the problem before now).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75741/new/
https://reviews.llvm.org/D75741
More information about the llvm-commits
mailing list