[PATCH] D76902: [PowerPC][AIX] ByVal formal argument support: multiple registers

Sean Fertile via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 31 07:09:33 PDT 2020


sfertile added a comment.

In D76902#1950131 <https://reviews.llvm.org/D76902#1950131>, @sfertile wrote:

> In D76902#1945938 <https://reviews.llvm.org/D76902#1945938>, @ZarkoCA wrote:
>
> > A small suggestion would be to add a test to further show that the GPRs are "burned" properly with with floats in the byval handling.  Eg. using a struct like `%struct.S31 = type <{ float, i32, i64, double, i32, double }>' and seeing the error that structs split regs and the stack are not handled.
>
>
> This is a really good suggestion. Going to add this next.


I forgot that Chris already did this in D76875 <https://reviews.llvm.org/D76875>: see the @test_byval_2Byte.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76902/new/

https://reviews.llvm.org/D76902





More information about the llvm-commits mailing list