[PATCH] D77139: GlobalISel: Move code into lowering for G_MERGE_VALUES
Dominik Montada via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 31 06:37:15 PDT 2020
gargaroff added inline comments.
================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:4826
+ if (DstTy.isPointer()) {
+ if (MIRBuilder.getDataLayout().isNonIntegralAddressSpace(
+ DstTy.getAddressSpace())) {
----------------
Should this check be done before we create new instructions? Not sure what the current policy for this is. I'm also fine with leaving it down here since it will abort legalization anyway.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77139/new/
https://reviews.llvm.org/D77139
More information about the llvm-commits
mailing list