[PATCH] D77050: [TTI] Remove getCallCost

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 31 06:37:15 PDT 2020


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM - we're trying to reduce and fix the cost model mess, so I'm fine with this step. If we want to add non-intrinsic call cost modeling in the future, it can be done without much effort when necessary.



================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfoImpl.h:865
+
+        return TTI::TCC_Basic * (FTy->getNumParams() + 1);
+      }
----------------
Copy over the existing code comment to explain this?
    // The target-independent implementation just measures the size of the
    // function by approximating that each argument will take on average one
    // instruction to prepare.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77050/new/

https://reviews.llvm.org/D77050





More information about the llvm-commits mailing list