[PATCH] D77138: [Alignment][NFC] Deprecate MachineMemOperand::getMachineMemOperand version that takes an untyped alignement.

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 31 06:37:13 PDT 2020


courbet accepted this revision.
courbet added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:4317
   EVT VT = Src0.getValueType();
-  unsigned Alignment = (cast<ConstantInt>(I.getArgOperand(2)))->getZExtValue();
+  MaybeAlign Alignment((cast<ConstantInt>(I.getArgOperand(2)))->getZExtValue());
   if (!Alignment)
----------------
extra parenthesis


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:4427
   EVT VT = TLI.getValueType(DAG.getDataLayout(), I.getType());
-  unsigned Alignment = (cast<ConstantInt>(I.getArgOperand(1)))->getZExtValue();
+  MaybeAlign Alignment((cast<ConstantInt>(I.getArgOperand(1)))->getZExtValue());
   if (!Alignment)
----------------
ditto


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77138/new/

https://reviews.llvm.org/D77138





More information about the llvm-commits mailing list