[PATCH] D76428: [cmake] Disable C4129 warning for MSVC.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 31 06:04:40 PDT 2020


fhahn abandoned this revision.
fhahn added a comment.

I've moved the expected raw string literals to variables in rG6120cb42f797 <https://reviews.llvm.org/rG6120cb42f7977290fac7a8ae1a7c06fc79beb5dc>. It looks like that was enough to silence the warning at least for the llvm-clang-x86_64-expensive-checks-win (http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/22891). Please let me know if there are any other configurations where this did not fix the warning.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76428/new/

https://reviews.llvm.org/D76428





More information about the llvm-commits mailing list