[PATCH] D77117: [RISCV] Split RISCVISelDAGToDAG.cpp to RISCVISelDAGToDAG.h and RISCVISelDAGToDAG.cpp
Shiva Chen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 31 04:56:43 PDT 2020
shiva0217 added a comment.
In D77117#1952051 <https://reviews.llvm.org/D77117#1952051>, @lenary wrote:
> Hi @shiva0217 can you clarify as to why this is necessary?
Hi @lenary,
For the downstream RISCV maintenance, it would be easier to inherent the RISCVISelDAGToDAG and only override the method need to customize for the custom provider ISA extension without touching RISCVISelDAGToDAG.cpp which may cause conflict when upgrading the downstream LLVM version.
I think it could be helpful for other RISCV downstream maintenance. Could it be the sufficient reason to split out the header?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77117/new/
https://reviews.llvm.org/D77117
More information about the llvm-commits
mailing list