[PATCH] D77128: [MLIR] Implement LoopLikeInterface for loop.parallel

[Theodore Popp via Phabricator via llvm-commits]

tpopp marked 2 inline comments as done.
tpopp added inline comments.


================
Comment at: mlir/test/Transforms/loop-invariant-code-motion.mlir:248
+
+func @parallel_loop_with_invariant() {
+  %c0 = constant 0 : index
----------------
bondhugula wrote:
> Please always include CHECK-LABEL's when you aren't using -split-input-file. There is otherwise the chance of CHECK's matching with previous function's output while developing / changing / adding tests and this could be quite painful. Looks like the other tests here aren't following the right convention as well and should be fixed.
I also split most test cases here. One test fails then, so I will have to follow up on that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77128/new/

https://reviews.llvm.org/D77128