[PATCH] D77132: [LLD][ELF] Follow the common pattern in a message about an undefined vtable symbol.

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin created this revision.
ikudrin added reviewers: ruiu, grimar.
ikudrin added projects: lld, LLVM.
Herald added subscribers: MaskRay, arichardson, emaste.
Herald added a reviewer: espindola.

In most cases, LLD prints its multiline diagnostic messages starting additional lines with ">>> ". That greatly helps external tools to parse the output, simplifying combining several lines of the log back into one message. The patch fixes the only message I found that does not follow the common pattern.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D77132

Files:
  lld/ELF/Relocations.cpp
  lld/test/ELF/undef.s


Index: lld/test/ELF/undef.s
===================================================================
--- lld/test/ELF/undef.s
+++ lld/test/ELF/undef.s
@@ -25,7 +25,7 @@
 # CHECK:      error: undefined symbol: vtable for Foo 
 # CHECK-NEXT: >>> referenced by undef.s
 # CHECK-NEXT: >>>               {{.*}}:(.text+0x15)
-# CHECK-NEXT: the vtable symbol may be undefined because the class is missing its key function (see https://lld.llvm.org/missingkeyfunction)
+# CHECK-NEXT: >>> the vtable symbol may be undefined because the class is missing its key function (see https://lld.llvm.org/missingkeyfunction)
 
 # Check that this symbol isn't demangled
 
Index: lld/ELF/Relocations.cpp
===================================================================
--- lld/ELF/Relocations.cpp
+++ lld/ELF/Relocations.cpp
@@ -901,8 +901,9 @@
   }
 
   if (sym.getName().startswith("_ZTV"))
-    msg += "\nthe vtable symbol may be undefined because the class is missing "
-           "its key function (see https://lld.llvm.org/missingkeyfunction)";
+    msg +=
+        "\n>>> the vtable symbol may be undefined because the class is missing "
+        "its key function (see https://lld.llvm.org/missingkeyfunction)";
 
   if (undef.isWarning)
     warn(msg);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77132.253830.patch
Type: text/x-patch
Size: 1241 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200331/76d43b4e/attachment-0001.bin>