[PATCH] D77016: Change AArch64 Windows EH UnwindHelp object to be a fixed object
Daniel Frampton via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 31 02:10:29 PDT 2020
danielframpton added a comment.
In D77016#1951715 <https://reviews.llvm.org/D77016#1951715>, @danielframpton wrote:
> In D77016#1950944 <https://reviews.llvm.org/D77016#1950944>, @danielframpton wrote:
>
> > In D77016#1950918 <https://reviews.llvm.org/D77016#1950918>, @efriedma wrote:
> >
> > > LGTM
> > >
> > > I assume you don't have commit access, so I'll commit it for you. How would you like me to credit you in the commit message (name and email address)?
> > >
> > > (The unnecessary alignment is probably something we could fix, but not worth the complexity.)
> >
> >
> > I do not have commit access, so that would be very helpful, Thanks! You can use Daniel Frampton <Daniel.Frampton at microsoft.com>
>
>
> I am doing some final validation of the version you accepted (using it to self-host rustc on windows). I will let you know that is complete.
My additional validation showed no issues. Please let me know if there is anything you need me to do.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77016/new/
https://reviews.llvm.org/D77016
More information about the llvm-commits
mailing list