[PATCH] D77060: [MLIR] Replace OpBuilder(Block) with AtBlockBegin and AtBlockEnd

Alex Zinenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 31 02:10:27 PDT 2020


ftynse added inline comments.


================
Comment at: mlir/include/mlir/IR/Builders.h:198
+  /// the Block.
+  static OpBuilder AtBlockBegin(Block *block) {
+    return OpBuilder(block, block->begin());
----------------
Nit: MLIR's convention for function names is to start with a small letter.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77060/new/

https://reviews.llvm.org/D77060





More information about the llvm-commits mailing list