[PATCH] D77121: [Alignment][NFC] Transitionning more getMachineMemOperand call sites
Guillaume Chatelet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 31 01:37:11 PDT 2020
gchatelet marked 2 inline comments as done.
gchatelet added inline comments.
================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.h:994
bool IsInvariant = false;
- unsigned Alignment = 0;
+ Align Alignment;
AAMDNodes AAInfo;
----------------
courbet wrote:
> This is a potential functional change, so I'll mention what I checked for posterity:
> There are three instantiations of this class. In all cases, `Alignment` is never read before being written to.
Yes I checked as well manually (by reading the code) and by running all tests and asserting when Alignment was read and equal to zero.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77121/new/
https://reviews.llvm.org/D77121
More information about the llvm-commits
mailing list