[PATCH] D75833: [RISCV] Support RISC-V ELF attribute section in llvm-readobj

[James Henderson via Phabricator via llvm-commits]

jhenderson requested changes to this revision.
jhenderson added a comment.
This revision now requires changes to proceed.

Sorry, I spotted the error handling is not using llvm-readobj's style. Please fix it.



================
Comment at: llvm/test/tools/llvm-readobj/ELF/RISCV/invalid-attr-version.test:1
+# RUN: yaml2obj %s -D BITS=32 -o %t.32.o
+# RUN: llvm-readobj -A %t.32.o 2>&1 | FileCheck %s
----------------
Let's add a top-level comment to this file explaining why this error exists.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:2726-2728
+      errs() << "Error: unrecognised FormatVersion: 0x"
              << Twine::utohexstr(Contents[0]) << '\n';
+      errs().flush();
----------------
Please use llvm-readobj's `reportError` function rather than hand-rolling your own error handling.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75833/new/

https://reviews.llvm.org/D75833