[PATCH] D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/tools/llvm-objdump/XCOFFDump.cpp:1
 //===-- XCOFFDump.cpp - XCOFF-specific dumper -------------------*- C++ -*-===//
 //
----------------
No need for the "C++" part of this line. That's only to help editors know that a header file is in C++ and to enable appropriate syntax highlighting. See https://llvm.org/docs/CodingStandards.html#file-headers.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.h:12
 #include "llvm/DebugInfo/DIContext.h"
+#include "llvm/Object/Archive.h"
 #include "llvm/Support/CommandLine.h"
----------------
DiggerLin wrote:
> hubert.reinterpretcast wrote:
> > Moving the include directive is the only change in this file from the patch. We don't need to touch this file at all.
> when git clang format, it will move the include directive automatically .
Only clang-format lines of code in the immediate area where you are modifying something. For example, it would be okay to modify this line if you are including a new header, but not otherwise.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72973/new/

https://reviews.llvm.org/D72973