[PATCH] D76921: [llvm-exegesis] 'Min' repetition mode
Clement Courbet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 30 23:58:06 PDT 2020
courbet added inline comments.
================
Comment at: llvm/tools/llvm-exegesis/lib/BenchmarkRunner.h:33
+extern cl::opt<exegesis::InstructionBenchmark::RepetitionModeE> RepetitionMode;
+
----------------
Let's avoid pushing tools flags down into libraries like this. This hinders testability and ties the inner classes to the tool main. What about just using `repetitors.size() > 1` ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76921/new/
https://reviews.llvm.org/D76921
More information about the llvm-commits
mailing list