[PATCH] D77079: [Alignment][NFC] GlobalIsel Utils inferAlignFromPtrInfo

Guillaume Chatelet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 30 23:25:40 PDT 2020


gchatelet marked 2 inline comments as done.
gchatelet added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/Utils.h:187-188
+
+/// FIXME: Remove once the transition to Align is over.
+inline unsigned inferAlignmentFromPtrInfo(MachineFunction &MF,
+                                          const MachinePointerInfo &MPO) {
----------------
arsenm wrote:
> There's no real need for this as there should only be one or two uses of this
Indeed thx there are only 6 instances.

I'll remove the function in my next patch which fixes the call sites.
FYI I prefer to proceed this way because the follow up patch is ready and fixing the call sites in this patch would be cumbersome.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77079/new/

https://reviews.llvm.org/D77079





More information about the llvm-commits mailing list