[PATCH] D76885: [lld][COFF][ELF][WebAssembly] Replace --[no-]threads /threads[:no] with --threads={all,1,2,...} /threads:{all,1,2,...}

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D76885#1951634 <https://reviews.llvm.org/D76885#1951634>, @ruiu wrote:

> Do we need `all`? It's the default behavior, so if you want to specify --threads=all, you can just delete it altogether.


`--threads=all` is a way to override a previous `--threads=3`. We just need a way to reset the behavior to a previous state. It is just for completeness.

> Are you going to make the same change for the other ports? I think wasm-ld mimics GNU linker's options, and I don't think we want to deviate too much from it, even if it simplifies the command line options.

--threads and --no-threads are gold-only options. They have currently mostly debug options. GNU ld does not have it. gold actually has more options but they are probably overkill:

  --thread-count COUNT
         Number of threads to use
  
  --thread-count-initial COUNT
         Number of threads to use in initial pass
  
  --thread-count-middle COUNT Number of threads to use in middle pass
  
  --thread-count-final COUNT
         Number of threads to use in final pass

For wasm-ld, @sbc100 mentioned that he can change his habit to adapt the new --threads=


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76885/new/

https://reviews.llvm.org/D76885