[PATCH] D77093: [SelectionDAGBuilder] Fix ISD::FREEZE creation for structs with fields of different types.
Juneyoung Lee via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 30 21:50:27 PDT 2020
aqjune added a comment.
Looks good to me, but maybe someone else who knows SelDag well should review this as well..?
================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:10556
+ ComputeValueVTs(DAG.getTargetLoweringInfo(), DAG.getDataLayout(), I.getType(),
+ ValueVTs);
+ unsigned NumValues = ValueVTs.size();
----------------
Realized that the original code had a problem with a nested struct type.
It would be great if there is a test for freeze with nested struct type.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77093/new/
https://reviews.llvm.org/D77093
More information about the llvm-commits
mailing list