[PATCH] D77082: [AMDGPU] Handle SMRD signed offset immediate
Stanislav Mekhanoshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 30 16:24:18 PDT 2020
rampitec added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp:1270
-Optional<int64_t> getSMRDEncodedOffset(const MCSubtargetInfo &ST,
- int64_t ByteOffset) {
+Optional<int64_t> getSMRDEncodedUnsignedOffset(const MCSubtargetInfo &ST,
+ int64_t ByteOffset) {
----------------
kerbowa wrote:
> rampitec wrote:
> > Should we instead pass here Subtarget and distinguish if it has needed mode right in this function?
> In that case we would also need to pass something to determine whether it's for S_BUFF since there is no signed offset there.
Ah, right.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77082/new/
https://reviews.llvm.org/D77082
More information about the llvm-commits
mailing list