[PATCH] D77082: [AMDGPU] Handle SMRD signed offset immediate

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp:1789
+  // GFX9 amd GFX10 have signed byte immediate offsets.
+  if (Subtarget->hasSMEMImmSignedOffset()) {
+    int64_t ByteOffset = C->getSExtValue();
----------------
Should this just rely on getSMRDEncodedSignedOffset failing based on the subtarget?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77082/new/

https://reviews.llvm.org/D77082