[PATCH] D76414: [mlir][Linalg] Introduce linalg.pooling_min/max/sum op.

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache accepted this revision.
nicolasvasilache added a comment.

Thanks for adding this!



================
Comment at: mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td:500
+        };
+    }
+  }];
----------------
hanchung wrote:
> mehdi_amini wrote:
> > This is quite a block of C++, can you move this all out of ODS?
> I'm following other ops style here. I'm happy to move all of them out of ODS, but can we keep it as this way for now?
> 
> Nicolas, do you have any comment/suggestion here?
A lot of these things will be auto-generated soon.
I have been personally moving things out of C++ and into Tablegen to reduce the number of places we need to modify.
I don't have a particular suggestion. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76414/new/

https://reviews.llvm.org/D76414