[PATCH] D76885: [lld][COFF][ELF][WebAssembly] Replace --[no-]threads /threads[:no] with --threads={all,1,2,...} /threads:{all,1,2,...}

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/ELF/Driver.cpp:1047
+    parallel::strategy.ThreadsRequested = threads;
+    config->thinLTOJobs = v;
+  }
----------------
aganea wrote:
> In absolute terms, do we really need two options for setting multi-threading? (`-threads=` for general-purpose code, and `-thinlto-jobs=` for ThinLTO threads)
> We can address this later, but it might complicate the setup for users. @tejohnson 
I had the same question:) I think even if people start to migrate to --threads, `-thinlto-jobs=` may be useful for debugging ThinLTO issues. --thinlto-jobs=1 can be used together with --save-temps, without slowding down other parallel loops. Whether this is worth a separate option needs more thoughts.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76885/new/

https://reviews.llvm.org/D76885