[PATCH] D39137: Add CallSiteSplitting pass

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/trunk/lib/Transforms/Scalar/CallSiteSplitting.cpp:370
+    }
+    break;
+  }
----------------
thakis wrote:
> Was this break supposed to be in the if above? As-is, it unconditionally breaks after the first iteration of the loop.
> 
> But even if it was a line further up, we'd only check the first Phi in the parent and check if it's an arg. I don't know if that's enough.
It looks like the code indeed bails out too early. I think we should check all PHIs. I've put up D77089. It should not matter if there are unrelated PHIs in between, but maybe the goal was to be extremely conservative @junbuml ?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D39137/new/

https://reviews.llvm.org/D39137