[PATCH] D77060: [MLIR] Make OpBuilder(Block) default to inserting at Block::begin().
Theodore Popp via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 30 10:16:55 PDT 2020
tpopp added a comment.
In D77060#1950238 <https://reviews.llvm.org/D77060#1950238>, @ftynse wrote:
> Could we rather have static constructors that make it explicit what the insertion point is?
Static builders (assuming you mean `OpBuilder b = OpBuilder::Get(body, body->begin())` ) and an explicit insertion point are orthogonal right? Or do you mean `OpBuilder::AtBlockBegin(body)`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77060/new/
https://reviews.llvm.org/D77060
More information about the llvm-commits
mailing list