[PATCH] D77025: [Object] Update ObjectFile::makeTriple for XCOFF

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 30 10:16:44 PDT 2020


hubert.reinterpretcast added a comment.

In D77025#1949281 <https://reviews.llvm.org/D77025#1949281>, @jhenderson wrote:

> Did you see that there are a bunch of test failures according to the pre-merge build? Don't know if they're related, but I guess that they are somehow.


Yes, I did. I am not sure that the pre-merge testing has proven to be reliably noise free. The functional behaviour change is limited to cases where the library returns "true" for `isXCOFF`; there is no reason to expect that to be the case for the environment that the failure logs report.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77025/new/

https://reviews.llvm.org/D77025





More information about the llvm-commits mailing list