[PATCH] D76810: [X86][NFC] Generalize the naming of "Retpoline Thunks" and related code to "Indirect Thunks" [1/3]

[Zola Bridges via Phabricator via llvm-commits]

zbrid added a comment.

Awesome. Looks good to me! Please wait for an LGTM from another LLVM contributor before merging.



================
Comment at: llvm/lib/Target/X86/X86FrameLowering.cpp:2708
       report_fatal_error("Emitting morestack calls on 64-bit with the large "
                          "code model and retpoline not yet implemented.");
     BuildMI(allocMBB, DL, TII.get(X86::CALL64m))
----------------
Does this comment need to be updated retpoline -> indirect thunks?


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:31817
     }
-    llvm_unreachable("unexpected reg for retpoline");
+    llvm_unreachable("unexpected reg for external retpoline");
   }
----------------
Jw, why add external here?


================
Comment at: llvm/lib/Target/X86/X86IndirectThunks.cpp:10
 ///
-/// Pass that injects an MI thunk implementing a "retpoline". This is
-/// a RET-implemented trampoline that is used to lower indirect calls in a way
----------------
Might be useful to keep a description of a retpoline in the top of this?

Like:
The currently supported thunks are:
retpoline - a RET-implemented trampoline that is used to lower indirect calls



================
Comment at: llvm/lib/Target/X86/X86IndirectThunks.cpp:17
+/// not a ModulePass is that ModulePasses at this point in the LLVM X86 pipeline
+/// serialize all transformations, which can consume lots of memory.
+///
----------------
Thanks for adding this documentation!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76810/new/

https://reviews.llvm.org/D76810