[PATCH] D76759: [AssumeBundles] Preserve Information from Load/Store
Johannes Doerfert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 30 08:03:52 PDT 2020
jdoerfert added a comment.
One last question
================
Comment at: llvm/lib/IR/KnowledgeRetention.cpp:202
+ addAttr(Attribute::NonNull, Pointer);
+ }
+ if (MA.valueOrOne() > 1)
----------------
I wonder if we have to guard the `nonnull` stuff with `DerefSize != 0`. This is only needed if we have "no-op" 0-length accesses, I think. I doubt those exist. Wdyt?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76759/new/
https://reviews.llvm.org/D76759
More information about the llvm-commits
mailing list