[PATCH] D77004: [MLIR] Fix permuteLoops utility
Andy Davis via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 30 08:03:46 PDT 2020
andydavis1 accepted this revision.
andydavis1 added a comment.
This revision is now accepted and ready to land.
Thanks for fixing this bug Uday!
================
Comment at: mlir/lib/Transforms/Utils/LoopUtils.cpp:754
+ continue;
+ auto *parentBlock = input[0].getOperation()->getBlock();
+ parentBlock->getOperations().splice(
----------------
Can you add some comments describing what is going on here? having 'input' indexed at a hard coded value of 0 needs explanation. Are you splicing ops from one loop before into the first loops parent block?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77004/new/
https://reviews.llvm.org/D77004
More information about the llvm-commits
mailing list