[PATCH] D76598: [GlobalISel] support narrow G_IMPLICIT_DEF for DstSize % NarrowSize != 0

Mon Mar 30 08:03:28 PDT 2020

arsenm added inline comments.

================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:747
+
+      MI.removeFromBundle();
+      return Legalized;
----------------
There's no bundle here? Why isn't this just an erase from parent?

================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-implicit-def-s1025.mir:10
+---
+name: test_implicit_def_s1025
+body: |
----------------
We should probably think about how to handle such degenerate cases, but I guess it's not critical

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76598/new/

https://reviews.llvm.org/D76598