[PATCH] D76567: AMDGPU: Implement getMemcpyLoopLoweringType
Jay Foad via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 30 07:33:11 PDT 2020
foad added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp:338
+ if ((SrcAddrSpace == AMDGPUAS::LOCAL_ADDRESS ||
+ SrcAddrSpace == AMDGPUAS::REGION_ADDRESS) &&
+ (DestAddrSpace == AMDGPUAS::LOCAL_ADDRESS ||
----------------
Shouldn't this `&&` be `||`, so we avoid forming either a 128-bit load or store?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76567/new/
https://reviews.llvm.org/D76567
More information about the llvm-commits
mailing list