[PATCH] D76998: [ARM] add ARMv8.6-A Activity monitors virtualization extension

Mon Mar 30 06:27:50 PDT 2020

SjoerdMeijer added inline comments.

================
Comment at: llvm/test/MC/AArch64/armv8.6a-amvs-error.s:1
+// RUN: not llvm-mc -triple aarch64 -show-encoding -o - %p/armv8.6a-amvs.s 2>&1  | FileCheck %s
+// CHECK: error: expected writable system register or pstate
----------------
ostannard wrote:
> SjoerdMeijer wrote:
> > I am unfamiliar with this: `%p/armv8.6a-amvs.s `, what is this doing?
> `%p` expands to the test source directory, so this test is using the code from an adjacent file, with the filecheck lines from this file. I think it would be better (more obvious, idiomatic) to merge the two files together using different check prefixes for the positive and negative cases.
cheers, and +1 to that

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76998/new/

https://reviews.llvm.org/D76998