[PATCH] D76920: [llvm-readobj] - Improve test of --elf-hash-histogram option.

Mon Mar 30 05:22:53 PDT 2020

grimar added inline comments.

================
Comment at: llvm/test/tools/llvm-readobj/ELF/hash-histogram.test:55-56
+      - Tag:   DT_HASH
+## The value of DT_HASH must be equal to the size of the .gnu.hash section.
+        Value: [[DTHASH]]
       - Tag:   DT_NULL
----------------
jhenderson wrote:
> Up to you, but you could avoid this macro by setting the AddressAlign property of the .hash section to some size, e.g. 0x100, and then just use that.
And alternative is to swap the order of `.hash` and `.gnu.hash`: the size of `.hash` is the same for 32/64 bit cases.
I've done it.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76920/new/

https://reviews.llvm.org/D76920