[PATCH] D76999: [ELF] Suggest VERSYM_HIDDEN shared definitions

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: lld/ELF/Relocations.cpp:903
+      if (name.data()[name.size()] == '@')
+        msg += name.data() + name.size();
+      msg += post_hint;
----------------
This is OK I think. Though I wonder if it would be cleaner to add a method to `Symbol` like:

```
 StringRef getFullName() const { return {nameData}; }
```

And just use it?


================
Comment at: lld/test/ELF/undef-suggest-version.s:16
+# CHECK-NEXT: >>> referenced by {{.*}}.o:(.text+0x6)
+# CHECK-NEXT: >>> did you mean: foo(int)@v1
+# CHECK-NEXT: >>> defined in: {{.*}}.so
----------------
Probably would be reasonable to add a test for `@@` case too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76999/new/

https://reviews.llvm.org/D76999