[PATCH] D76885: [lld][COFF][ELF][WebAssembly] Replace --[no-]threads /threads[:no] with --threads={all,1,2,...} /threads:{all,1,2,...}
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 30 02:07:52 PDT 2020
grimar added inline comments.
================
Comment at: lld/test/ELF/threads.test:1
+# RUN: yaml2obj %s -o %t.o
+
----------------
`llvm-mc /dev/null -o %t.o -filetype=obj -triple=xxx`?
(the same for the wasm test)
================
Comment at: lld/test/ELF/threads.test:12
+
+# CHECK: error: --threads: expected 'all' or a positive integer, but got '{{.*}}'
+
----------------
Perhaps use `FileCheck -DVAL=xxx` to make checks explicit?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76885/new/
https://reviews.llvm.org/D76885
More information about the llvm-commits
mailing list