[PATCH] D76822: [VE] Update lea/load/store instructions

Mon Mar 30 01:35:25 PDT 2020

kaz7 marked 3 inline comments as done.
kaz7 added inline comments.

================
Comment at: llvm/lib/Target/VE/VEISelDAGToDAG.cpp:159
+
   if (Addr.getOpcode() == ISD::ADD) {
     if (Addr.getOperand(0).getOpcode() == VEISD::Lo ||
----------------
simoll wrote:
> kaz7 wrote:
> > simoll wrote:
> > > This is a generalized version of `SelectionDAG::isBaseWithConstantOffset`. I suppose this code (up until line 177) should be moved into SelectionDAG, eg as `SelectionDAG::isBaseWithOffset`.
> > > You can do that in a followup patch.
> > Regarding to isBaseWithOffset, I'll try that.  Should I submit them as independent patch or just append modifications on SelectionDAG in this patch?
> Better make it a separate patch for Phabricator after this patch is committed.
I will do.  Thanks.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76822/new/

https://reviews.llvm.org/D76822