[PATCH] D76903: Add a flag on the context to protect against creation of operations in unregistered dialects
River Riddle via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Mar 29 16:04:40 PDT 2020
rriddle accepted this revision.
rriddle added inline comments.
================
Comment at: mlir/include/mlir/IR/MLIRContext.h:56
+ /// Enables creating operations in unregistered dialects.
+ void allowUnregisteredDialects(bool allowing = true);
+
----------------
nit: allowing -> allow
================
Comment at: mlir/lib/Analysis/Verifier.cpp:209
+ "MLIRContext, or use -allow-unregistered-dialect with "
+ "mlir-opt";
+
----------------
nit: Should we really mention mlir-opt here? Especially given that many users have their own opt equivalents?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76903/new/
https://reviews.llvm.org/D76903
More information about the llvm-commits
mailing list