[PATCH] D76903: Add a flag on the context to protect against creation of operations in unregistered dialects
Mehdi AMINI via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Mar 29 12:17:59 PDT 2020
mehdi_amini added inline comments.
================
Comment at: mlir/lib/IR/MLIRContext.cpp:168
+
+ // In most cases, creating operation in unregistered dialect is not desired
+ // and indicate a misconfiguration of the compiler. This option enables to
----------------
rriddle wrote:
> Please use /// for comments.
I had modeled on the data members above :
```
// Identifier allocator and mutex for thread safety.
llvm::BumpPtrAllocator identifierAllocator;
llvm::sys::SmartRWMutex<true> identifierMutex;
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76903/new/
https://reviews.llvm.org/D76903
More information about the llvm-commits
mailing list