[PATCH] D73480: [VectorCombine] new IR transform pass for partial vector ops

[Sanjay Patel via Phabricator via llvm-commits]

spatel marked 3 inline comments as done.
spatel added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VectorCombine.cpp:96
+    //       iteratively in this loop rather than waiting until the end.
+    for (Instruction &I : make_range(BB.rbegin(), BB.rend())) {
+      MadeChange |= foldExtractCmp(I, TTI);
----------------
xbolva00 wrote:
> xbolva00 wrote:
> > Skip debug insn?
> > 
> > DbgInfoIntrinsic?
> And skip “cold” blocks?
I don't think there's enough going on in this pass yet to make this measurable, but:
rGfc3cc8a4b074


================
Comment at: llvm/lib/Transforms/Vectorize/VectorCombine.cpp:96
+    //       iteratively in this loop rather than waiting until the end.
+    for (Instruction &I : make_range(BB.rbegin(), BB.rend())) {
+      MadeChange |= foldExtractCmp(I, TTI);
----------------
spatel wrote:
> xbolva00 wrote:
> > xbolva00 wrote:
> > > Skip debug insn?
> > > 
> > > DbgInfoIntrinsic?
> > And skip “cold” blocks?
> I don't think there's enough going on in this pass yet to make this measurable, but:
> rGfc3cc8a4b074
Is there a pass that we can view as a template for this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73480/new/

https://reviews.llvm.org/D73480