[PATCH] D76659: [mlir][Pass] Add support for generating pass utilities via tablegen

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: mlir/lib/Dialect/Quant/Transforms/ConvertConst.cpp:27
+#define GEN_PASS_QuantConvertConst
+#include "mlir/Dialect/Quant/Passes.h.inc"
 
----------------
Have you looked into generating normal top-level headers (maybe even one per pass) that would put define a base class for each of the pass so you could just inherit from it?

```
#include "milr/Dialect/Quant/ConvertConstPassGen.h"

struct ConvertConstPass : public ConvertConstPassBase {

}
```



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76659/new/

https://reviews.llvm.org/D76659