[PATCH] D39137: Add CallSiteSplitting pass

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 29 10:40:47 PDT 2020


thakis added inline comments.
Herald added subscribers: danielkiss, dexonsmith, steven_wu, hiraditya.


================
Comment at: llvm/trunk/lib/Transforms/Scalar/CallSiteSplitting.cpp:370
+    }
+    break;
+  }
----------------
Was this break supposed to be in the if above? As-is, it unconditionally breaks after the first iteration of the loop.

But even if it was a line further up, we'd only check the first Phi in the parent and check if it's an arg. I don't know if that's enough.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D39137/new/

https://reviews.llvm.org/D39137





More information about the llvm-commits mailing list