[PATCH] D76720: [Transforms][SROA] Promote allocas with mem2reg for scalable types

Sun Mar 29 06:55:03 PDT 2020

c-rhodes added a comment.

In D76720#1947128 <https://reviews.llvm.org/D76720#1947128>, @efriedma wrote:

> I'd like to see better test coverage here.  At least, a case that can't be promoted, and a case where a scalable alloca lands on the worklist despite the check in SROA::runImpl.

I've added a test for a scalable alloca that can't be promoted. I'm not really sure how test the latter, unless you're thinking about the bug you spotted, in which case the test I've added should cover that?

We shouldn't hit it but we do skip scalable allocas in `runOnAlloca`.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76720/new/

https://reviews.llvm.org/D76720