[PATCH] D76913: [Coroutines 2/2] Improve symmetric control transfer feature

JunMa via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 28 20:24:25 PDT 2020


junparser marked an inline comment as done.
junparser added inline comments.


================
Comment at: llvm/lib/Transforms/Coroutines/CoroSplit.cpp:971
+          Value *V = CondCmp->getOperand(0);
+          auto it = ResolvedValues.find(V);
+          if (it != ResolvedValues.end())
----------------
modocache wrote:
> I don't have an opinion either way, but just for information the clang-tidy pre-merge check thinks you ought to name this variable `It` with a capital `I`, that's why it's failing on this revision.
Thanks for the info, It seems better to keep same with below code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76913/new/

https://reviews.llvm.org/D76913





More information about the llvm-commits mailing list