[PATCH] D77004: [MLIR] Fix permuteLoops utility

Uday Bondhugula via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 28 19:20:29 PDT 2020


bondhugula created this revision.
bondhugula added reviewers: andydavis1, dcaballe.
Herald added subscribers: llvm-commits, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, burmako, jpienaar, rriddle, mehdi_amini, mgrang, mgorny.
Herald added a project: LLVM.
bondhugula updated this revision to Diff 253392.
bondhugula added a comment.
bondhugula added a parent revision: D77003: [MLIR] Add missing asserts in interchangeLoops util, doc comment update.
bondhugula edited the summary of this revision.

Update child revision


Rewrite mlir::permuteLoops for affine loop permutation to fix incorrect
approach. Avoiding using sinkLoops entirely - use single move approach.
Add test pass.

This fixes https://bugs.llvm.org/show_bug.cgi?id=45328

Depends on D77003 <https://reviews.llvm.org/D77003>.

Signed-off-by: Uday Bondhugula <uday at polymagelabs.com>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D77004

Files:
  mlir/include/mlir/Transforms/LoopUtils.h
  mlir/lib/Transforms/Utils/LoopUtils.cpp
  mlir/test/Dialect/Affine/loop-permute.mlir
  mlir/test/lib/Dialect/Affine/CMakeLists.txt
  mlir/test/lib/Dialect/Affine/TestLoopPermutation.cpp
  mlir/tools/mlir-opt/mlir-opt.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77004.253392.patch
Type: text/x-patch
Size: 10842 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200329/0b312ed2/attachment-0001.bin>


More information about the llvm-commits mailing list