[PATCH] D76951: [llvm-rc] Allow -1 for menu item IDs

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 28 09:40:13 PDT 2020


rnk added a comment.

I was going to say, perhaps we should truncate to signed `int16_t` and check that the value round trips. This would allow negative values, but ban positive values above ~32K. If we ever see a use of -2, -3, etc, that's the logical next step.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76951/new/

https://reviews.llvm.org/D76951





More information about the llvm-commits mailing list