[PATCH] D29014: [SelDag] Add FREEZE

Fri Mar 27 22:32:40 PDT 2020

aqjune added a comment.

In D29014#1946763 <https://reviews.llvm.org/D29014#1946763>, @JamesNagurne wrote:

> @aqjune
>
> @bkramer committed a fix for a crash in LegalizeFloatTypes where this operator appeared in SoftPromoteHalfResult
>
> Our downstream ARM compiler is crashing in regressions in a similar manner in SoftenFloatResult in the same file. Is it not conceivable that ISD::FREEZE might make it to this function? If that's the case, we can look into it and start up a new review if necessary. The test causing this crash is select-cc.ll.

Hi, I saw @bkramer 's fix too (commit id 0019c2f194a5e1f4cd65c5284e204328cc40ab3d <https://reviews.llvm.org/rG0019c2f194a5e1f4cd65c5284e204328cc40ab3d> ), and I think it is a valid fix. Similar thing can be applied to the SoftenFloatResult function. I'll make a patch for this.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D29014/new/

https://reviews.llvm.org/D29014