[PATCH] D73656: [mlir][Linalg] Add a Linalg DRR test to go from matmul to vectors
Mehdi AMINI via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 27 22:00:22 PDT 2020
mehdi_amini added a comment.
In D73656#1947477 <https://reviews.llvm.org/D73656#1947477>, @nicolasvasilache wrote:
> @mehdi_amini this is a custom test pass that tests all the patterns compose nicely all the way to vector.
> Last I tried they actually didn't compose nicely and I need to debug.
> How is this an example more than a test pass?
You testing pass is testing patterns that are in the test directory as well. This looks all self-contained to me: so it isn't clear to me what is this testing that isn't already tested.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73656/new/
https://reviews.llvm.org/D73656
More information about the llvm-commits
mailing list