[PATCH] D76885: [lld][ELF][WebAssembly] Replace --(no-)threads with --threads={all,1,2,...}

Fri Mar 27 17:05:44 PDT 2020

MaskRay marked an inline comment as done.
MaskRay added inline comments.

================
Comment at: lld/wasm/Driver.cpp:387
+            ": expected 'all' or a positive integer, but got '" +
+            arg->getValue() + "'");
+    config->thinLTOJobs = v;
----------------
sbc100 wrote:
> Just, FYI, if there is sufficient code shared with the ELF linker there we do have `Common/Args.h` as a place to share common arg processing code.    
I know `Common/Args.h`. `OPT_threads` and `config` are of different types in ELF and in wasm, so sharing may not simplify the code.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76885/new/

https://reviews.llvm.org/D76885